Skip to content

IAM policies on Secret Manager on single Elastic CI Stack note #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pages/agent/v3/aws/secrets_manager.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ To ensure your Elastic CI Stack for AWS has access to the secret:
}
```

>📘 Single instance Elastic CI Stacks
> If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup.
Comment on lines +49 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a little simpler/clearer:

Suggested change
>📘 Single instance Elastic CI Stacks
> If you have set `minSize` and `maxSize` parameters equal to 1 in your [Elastic CI Stack parameters](/docs/agent/v3/elastic-ci-aws/parameters), you will only need to set the `IAMRole` to your Secret Manager secret's resource policy as above. The `AutoscalingLambdaExecutionRole` IAM role and corresponding autoscaling resources are not created in this Elastic CI Stack setup.
>📘 Single instance stacks
> If you have set `minSize` and `maxSize` [parameters](/docs/agent/v3/elastic-ci-aws/parameters) equal to `1`, don't include the `AutoscalingLambdaExecutionRole` IAM role in the resource policy. Only the `IAMRole` is required since this setup doesn't need autoscaling resources.

But it's a little less precise, so happy to go with your version if you think it works better. Let me know what you think.


## Multi-region replication

It is also possible to replicate your Buildkite Agent token to multiple regions
Expand Down