Add NestedVirtualizationEnabled launch-template parameter

[iangmaia]

Description

Adds a NestedVirtualizationEnabled stack parameter and sets CpuOptions.NestedVirtualization=enabled on the agent launch template.

Note - local validation is blocked:

• cfn-lint templates/aws-stack.yml fails with E3002 on CpuOptions.NestedVirtualization
• Reproduced with the repo-pinned cfn-lint==1.36.0 and cfn-lint==1.48.1
• EC2 API docs: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_LaunchTemplateCpuOptionsRequest.html
• EC2 user guide: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/amazon-ec2-nested-virtualization.html
• CloudFormation docs do not currently list NestedVirtualization: https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-ec2-launchtemplate-cpuoptions.html

Checklist

• Tests pass locally
• Added tests for new features/fixes
• Updated documentation (if applicable)
• Linting checks pass

Release Notes

• Public API: add NestedVirtualizationEnabled stack parameter for c8i, m8i, r8i, and their flex variants
• My changes affect the public API (variable renames, new stack parameters, etc)
  • I have added a note at the top of the release notes highlighting the API changes
• Any changes to external libraries (agent, scaler function, etc) have been flagged in release notes

[iangmaia]

cc: @petetomasik (not sure who to tag for a review but just wanted to bring this to someone's attention, as it would be nice to allow for nested virtualization in certain EC2 instance types)

[JoeColeman95]

Hey @iangmaia

Thanks for the contribution! 🎉

Can see that this is indeed a valid option, but not for CloudFormation, unfortunately. We could theoretically avoid this by adding an ignore check for E3002 here, but, the problem is that this'll just be rejected as the CFN schema explicitly rejects additional options:

    "CpuOptions" : {
      "description" : "Specifies the CPU options for an instance. For more information, see [Optimize CPU options](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-optimize-cpu.html) in the *User Guide*.\n ``CpuOptions`` is a property of [AWS::EC2::LaunchTemplate LaunchTemplateData](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-launchtemplatedata.html).",
      "additionalProperties" : false,
      "type" : "object",
      "properties" : {
        "ThreadsPerCore" : {
          "description" : "The number of threads per CPU core. To disable multithreading for the instance, specify a value of ``1``. Otherwise, specify the default value of ``2``.",
          "type" : "integer"
        },
        "AmdSevSnp" : {
          "description" : "Indicates whether to enable the instance for AMD SEV-SNP. AMD SEV-SNP is supported with M6a, R6a, and C6a instance types only. For more information, see [AMD SEV-SNP for Amazon EC2 instances](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/sev-snp.html).",
          "type" : "string",
          "enum" : [ "enabled", "disabled" ]
        },
        "CoreCount" : {
          "description" : "The number of CPU cores for the instance.",
          "type" : "integer"
        }
      }
    },

I'd say we're best to wait on AWS here for this to be supported before proceeding further with a review?

[JoeColeman95]

As a side note @iangmaia, I will check on the status of this periodically and will update once this is available.

[iangmaia]

I'd say we're best to wait on AWS here for this to be supported before proceeding further with a review?

Agreed 👍 I'm not sure how that usually goes but hopefully it won't take long?

As a side note @iangmaia, I will check on the status of this periodically and will update once this is available.

Thanks a lot!