fix the solution

bumzy · May 3, 2016 · b4a8cf1 · b4a8cf1
1 parent ba81d27
commit b4a8cf1
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/ch13/ex13_08.h b/ch13/ex13_08.h
@@ -19,17 +19,12 @@ class HasPtr {
     HasPtr(const std::string &s = std::string()) : ps(new std::string(s)), i(0) { }
     HasPtr(const HasPtr &hp) : ps(new std::string(*hp.ps)), i(hp.i) { }
     HasPtr& operator=(const HasPtr &rhs_hp) {
-        if(this != &rhs_hp){  // there is no need to assign for
-                              // the same instance.
-
-            HasPtr temp_HasPtr(rhs_hp);
-            std :: string *temp_ps = temp_HasPtr.ps;
-            temp_HasPtr.ps = ps;
+        if(this != &rhs_hp){
+            std :: string *temp_ps = new std :: string(*rhs_hp);
+            delete ps;
             ps = temp_ps;
-
-            i = temp_HasPtr.i;
-        }  // temp_HasPtr's destructor will be called,
-           // the memory allocated by original instance will be freed.
+            i = rhs_hp.i;
+        }
         return *this;
     }
 private: