Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change quotes #13

Merged
merged 14 commits into from
Jan 9, 2025
Merged

Fix change quotes #13

merged 14 commits into from
Jan 9, 2025

Conversation

ryanwithawhy
Copy link
Collaborator

Removes quoted = True from object identifiers for databases and schemas. However, if a user passes a quoted identifier it will treat it as quoted even with quoted=True not set.

Creates test cases for object identifiers.

Updates utils.universql_connection and utils.snowflake_connection to take a connection name. If not provided the connection name will default to existing rules.

Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@buremba buremba merged commit a328158 into main Jan 9, 2025
0 of 2 checks passed
@buremba
Copy link
Owner

buremba commented Jan 9, 2025

Thanks for the PR! ❄️🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants