feature/add utils get records #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavigne958
force-pushed
the
feature/add_utils_get_records
branch
from
4c1aea3 to
7ddfd50
Compare
Add the new section in the v6 migration guide about the method `Worksheet.get_all_records` to allow users to migrate from previous method signature to the new one. closes #1376 Signed-off-by: Alexandre Lavigne <[email protected]>
Add a new util function that helps building record values.
Records are list of dictionaries, each dictionary has the same
set of keys, they are set from the given list of headers.
Each key is associated to a value from the given matrix of values.
They are as many dictionaries as they are lines in the matrix.
Each line in the matrix will be associated to a dictionary,
each key is associated to a value from that line in the given order.
Example:
Headers: A B C
Values:
1 2 3
7 8 9
Result: [ { A: 1, B: 2, C: 3}, {A: 7, B: 8, C: 9}]
closes #1367
Signed-off-by: Alexandre Lavigne <[email protected]>
lavigne958
force-pushed
the
feature/add_utils_get_records
branch
from
7ddfd50 to
de307cb
Compare
|
thought I could re-open the PR but no, I had to rebase it on tarrget branch then cherry-pick the original commit 😉 ready for review with:
|
alifeee
approved these changes
Jan 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_all_recordscloses #1376
closes #1367
closes #976