This repository was archived by the owner on Sep 27, 2020. It is now read-only.
use message ID 0 for log messages #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the client sends the request server info message with ID 1. if the log messages also have ID 1, the client may interpret log messages sent by the server during initial connect (for example, the message which logs the connection) as reply to request server info, which makes it break in ButtplugClient.java:169 (requestServerInfo()).
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the client sends the request server info message with ID 1. if the
log messages also have ID 1, the client may interpret log messages
sent by the server during initial connect (for example, the message
which logs the connection) as reply to request server info, which
makes it break in ButtplugClient.java:169 (requestServerInfo()).