fix: Await on WebSocket connect to enable exception catching#5
Merged
qdot merged 1 commit intobuttplugio:masterfrom Feb 25, 2025
tsunosekai:await-websocket-connect
Merged
fix: Await on WebSocket connect to enable exception catching#5qdot merged 1 commit intobuttplugio:masterfrom tsunosekai:await-websocket-connect
qdot merged 1 commit intobuttplugio:masterfrom
tsunosekai:await-websocket-connect
Conversation
|
|
Contributor
Author
|
@qdot |
Member
|
Wow I really gotta start figuring out how to get notifications on outstanding PRs. Merged at least. I'll see about doing another release soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've submitted a fix for the error handling during the ButtplugClient.connect() await process.
This ensures exceptions are now catchable. Details are in the attached commits.
Best,