-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lang/rust): link to old WIT, prose & interface use example #222
Merged
kate-goldenring
merged 5 commits into
bytecodealliance:main
from
vados-cosmonic:fix(rust)=wit-link-and-prose-for-interfaces-with-example
Apr 7, 2025
Merged
fix(lang/rust): link to old WIT, prose & interface use example #222
kate-goldenring
merged 5 commits into
bytecodealliance:main
from
vados-cosmonic:fix(rust)=wit-link-and-prose-for-interfaces-with-example
Apr 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
itowlson
reviewed
Mar 26, 2025
itowlson
reviewed
Mar 26, 2025
6e5799f
to
28c3a79
Compare
Hey itowlson kate-goldenring thanks for the reviews -- this should be ready for another look! |
itowlson
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many apologies for my confusion over this, and thanks for your patience @vados-cosmonic!
Absolutely no problem! Yeah the example was doing the other thing until just this week/last week so I totally get it. Thanks for taking another look!
…On Friday, March 28th, 2025 at 8:09 AM, itowlson ***@***.***> wrote:
@itowlson approved this pull request.
Many apologies for my confusion over this, and thanks for your patience ***@***.***(https://github.com/vados-cosmonic)!
—
Reply to this email directly, [view it on GitHub](#222 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A5RZU77MOWSRTMSKOMEMMM32WSAKTAVCNFSM6AAAAABZVJ2FWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRTHA3TANZTGE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Signed-off-by: Victor Adossi <[email protected]>
Co-authored-by: Kate Goldenring <[email protected]>
Co-authored-by: Kate Goldenring <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
28c3a79
to
534c3ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.