-
Notifications
You must be signed in to change notification settings - Fork 63
fix: hack around mdbook-linkcheck warnings #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hack around mdbook-linkcheck warnings #224
Conversation
This commit introduces a hack that suppresses mdbook-linkcheck warnings for link-like alert constructs like `[!NOTE]`, until an upstream fix can be merged. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
What's the issue here? |
Ah the issue here is that Before
(NOTE: there's a "real" error tucked in the before output above :) After
|
Ah also relevant -- this came up while working on #218 (comment) (would appreciate reviews/attention there!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining! I'm good to go with this as long as it doesn't affect the rendered output.
Yeah that's a really good point -- I made sure to check locally. At least in my browser, everything renders properly still and the warning boxes are warnings/etc. |
Build is now failing with:
Although I don't get how that can be related...? |
That's definitely odd -- is it possible that CI error is different/unrelated? is it possible |
This commit introduces a hack that suppresses mdbook-linkcheck warnings for link-like alert constructs like
[!NOTE]
, until an upstream fix can be merged.