Skip to content

fix(ci): deploy path for book #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vados-cosmonic
Copy link
Contributor

This commit fixes the deploy path (which changes slightly, due to mdbook-linkcheck)

This commit fixes the deploy path (which changes slightly, due to mdbook-linkcheck)

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@vados-cosmonic
Copy link
Contributor Author

Hey @itowlson would you mind taking a look at this PR really quick -- it looks like adding mdbook-linkcheck changes the output directory just slightly (puts the output in /html) which breaks the deploy CI

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@itowlson
Copy link
Collaborator

Fingers crossed, otherwise maybe we're best rolling it all back until we can test e2e?

@itowlson itowlson merged commit dcc9149 into bytecodealliance:main Mar 25, 2025
@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Mar 25, 2025

WHEW! Thank you @itowlson 🙇

I'm fairly certain this is the fix. I also added a clear test to make sure this doesn't happen again in the deploy CI step (i.e. I look for /index.html in the deploy dir) -- thanks for taking another look so late 🙇

[EDIT] Also once #226 is rebased and merged the builds both in PRs and for deploy should be dramatically faster.

@itowlson
Copy link
Collaborator

CI is still breaking, and I'm about to become busy for the evening. Maybe the safest thing to do is reset to a previous successful build, then take it step by step tomorrow, this time starting from your "run mdbook on PRs" PR?

@vados-cosmonic
Copy link
Contributor Author

Ironically the bash check I inserted is what failed -- please feel free to go back to the previous build, we'll pick it up tomorrow

@vados-cosmonic vados-cosmonic deleted the fix(ci)=fix-deploy-path branch March 25, 2025 05:08
@itowlson
Copy link
Collaborator

I've merged the fix, fingers even crosseder than before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants