Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate private resource constructors when none are defined #548

Merged
merged 1 commit into from
Jan 25, 2025
Merged

generate private resource constructors when none are defined #548

merged 1 commit into from
Jan 25, 2025

Conversation

OmarTawfik
Copy link
Contributor

Closes #543

@OmarTawfik OmarTawfik marked this pull request as ready for review January 24, 2025 11:21
@OmarTawfik
Copy link
Contributor Author

cc @guybedford
Not sure about the CI errors, given that the same tests succeed on other platforms. Looks like the issues already exists in main. Thoughts?

@guybedford
Copy link
Collaborator

This looks great, thank you for working on this!

@guybedford guybedford merged commit 5b2617d into bytecodealliance:main Jan 25, 2025
18 of 19 checks passed
@OmarTawfik OmarTawfik deleted the private-ctor branch January 27, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript definitions expose constructors even when none exist
2 participants
@OmarTawfik @guybedford