Skip to content

Implement core::error::Error for ParseError #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevefan1999-personal wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement core::error::Error for ParseError #132

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cd20a6
Implement core::error::Error for ParseError
stevefan1999-personal Jun 8, 2026
1e78c4c
Update build.rs
stevefan1999-personal Jun 8, 2026
1480f3d
remove the feature; use rust-version for minimal version guarantee
stevefan1999-personal Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/parse_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ impl fmt::Display for ParseError {
}
}

#[cfg(feature = "std")]
impl std::error::Error for ParseError {}
impl core::error::Error for ParseError {}

@bjorn3 bjorn3 Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSRV is 1.34. core::error::Error doesn't exist until 1.81. You may need to add something like

target-lexicon/build.rs

Lines 55 to 57 in 2d53442

if using_1_40() {
println!("cargo:rustc-cfg=feature=\"rust_1_40\"");
}

Loading