Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-gem action #420

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update cross-gem action #420

merged 2 commits into from
Jan 14, 2025

Conversation

jbourassa
Copy link
Collaborator

@jbourassa jbourassa commented Jan 14, 2025

Update cross-gem action, should fix #418.

Changes:

  • Update the cross-gem action the release and build-gem workflows
  • Update to latest upload+download artifacts
  • Replace yet another Ruby 3.3 by Ruby 3.4
  • Update rb-sys to fix the compilation getting killed (issue described in No precompiled gem for Ruby 3.3 #418)

This should work; I ran a similar workflow that included oxidize-rb/rb-sys#487 and all the *.gem were generated, in the right folder, and had precompiled binaries for all Ruby versions (code, run)

@jbourassa jbourassa marked this pull request as ready for review January 14, 2025 12:39
@jbourassa
Copy link
Collaborator Author

There's 3 pending checks because the ruby version is now 3.3.5 in the matrix. Once it merges we can go update the merge requirements.

IIUC soon the matrix will include minor versions for all ruby versions, syncing between the GitHub config and ruby minor releases will create toil. I wonder if we could avoid it somehow.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close #419, in favor of this one, which is in a more complete state.

@jbourassa jbourassa merged commit ad12590 into main Jan 14, 2025
29 checks passed
@jbourassa jbourassa deleted the update-cross-gem branch January 14, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No precompiled gem for Ruby 3.3
2 participants