Skip to content

Conversation

alexcrichton
Copy link
Member

This commit adds a test where a stream of data is being sent over TCP and the read side reads as much as it can and then cancels any read that shows up pending. It then waits for readiness via a 0-length read and retries again. The test is intended to assert that the number of consecutive zero-length reads reported is capped at some small number (e.g. this shouldn't infinite loop).

Copy link
Member Author

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on #11611

This commit adds a test where a stream of data is being sent over TCP
and the read side reads as much as it can and then cancels any read that
shows up pending. It then waits for readiness via a 0-length read and
retries again. The test is intended to assert that the number of
consecutive zero-length reads reported is capped at some small number
(e.g. this shouldn't infinite loop).
@alexcrichton alexcrichton marked this pull request as ready for review September 8, 2025 20:26
@alexcrichton alexcrichton requested review from a team as code owners September 8, 2025 20:26
@alexcrichton alexcrichton requested review from pchickey and removed request for a team September 8, 2025 20:26
@alexcrichton
Copy link
Member Author

Ok after #11625 this is now ready to merge

@alexcrichton alexcrichton moved this from Backlog to In progress in Ship WASIp3 Sep 8, 2025
@alexcrichton alexcrichton self-assigned this Sep 8, 2025
@alexcrichton alexcrichton added this pull request to the merge queue Sep 8, 2025
Merged via the queue into bytecodealliance:main with commit 525794c Sep 8, 2025
44 checks passed
@alexcrichton alexcrichton deleted the stream-tests branch September 8, 2025 22:50
@github-project-automation github-project-automation bot moved this from In progress to Done in Ship WASIp3 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants