Skip to content

Conversation

@TartanLlama
Copy link
Contributor

@TartanLlama TartanLlama commented Sep 29, 2025

Implements WebAssembly/component-model#557

  • Pass through all new builtins
  • Basic implementations of new builtins
  • Cancellation support
  • Support for explicit threads continuing after the implicit thread has exited
  • Match trap conditions with the spec (deferred)
  • Insert threads into the instance table rather than holding them inside GuestTask
  • Don't reuse the existing GuestCall functionality for new threads
  • Testing (partially implemented, further testing deferred)
  • Revert changes to the component_model_async_builtins and component_model_async_stackful features

prtest:full

@github-actions github-actions bot added fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Sep 29, 2025
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@TartanLlama
Copy link
Contributor Author

Created issues #11910 #11909 #11908 to track deferred work

@TartanLlama
Copy link
Contributor Author

@alexcrichton @dicej I think we're good to go. For CI to go green, we'd need to have WebAssembly/component-model#570 and WebAssembly/component-model#557 merged into the component model repo. What do we think about getting them merged soon @lukewagner ?

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also feel free to update this function --

pub fn should_fail(&self, config: &WastConfig) -> bool {
-- to avoid blocking on PRs and go ahead and land this with known-failing tests

@lukewagner
Copy link
Contributor

lukewagner commented Oct 23, 2025

@TartanLlama That is fantastic to hear! I merged CM/#570. Do you suppose you could post a note on CM/#557 noting that it has been implemented and you think it's good to merge?

@alexcrichton alexcrichton added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
Copy link
Collaborator

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple freestanding comments, but they are minor and can probably be deferred if relevant.

@TartanLlama
Copy link
Contributor Author

@alexcrichton looks like one of the tests I added was missing a Miri ignore directive which failed the merge, I've added it

@alexcrichton alexcrichton added this pull request to the merge queue Oct 27, 2025
Merged via the queue into bytecodealliance:main with commit e06fbf7 Oct 27, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants