-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Cooperative Multithreading #11751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooperative Multithreading #11751
Conversation
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
|
@alexcrichton @dicej I think we're good to go. For CI to go green, we'd need to have WebAssembly/component-model#570 and WebAssembly/component-model#557 merged into the component model repo. What do we think about getting them merged soon @lukewagner ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also feel free to update this function --
wasmtime/crates/test-util/src/wast.rs
Line 404 in 710ba4b
| pub fn should_fail(&self, config: &WastConfig) -> bool { |
|
@TartanLlama That is fantastic to hear! I merged CM/#570. Do you suppose you could post a note on CM/#557 noting that it has been implemented and you think it's good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple freestanding comments, but they are minor and can probably be deferred if relevant.
|
@alexcrichton looks like one of the tests I added was missing a Miri ignore directive which failed the merge, I've added it |
Implements WebAssembly/component-model#557
GuestTaskGuestCallfunctionality for new threadscomponent_model_async_builtinsandcomponent_model_async_stackfulfeaturesprtest:full