Skip to content

Gate synchronous future/stream read/write separately#13217

Open
alexcrichton wants to merge 2 commits intobytecodealliance:mainfrom
alexcrichton:gate-sync
Open

Gate synchronous future/stream read/write separately#13217
alexcrichton wants to merge 2 commits intobytecodealliance:mainfrom
alexcrichton:gate-sync

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This commit renames the previous wasm_component_model_async_builtins feature to wasm_component_model_more_async_builtins and then moves synchronous future/stream reads/writes behind this feature. This is inspired by #13212 and corresponds to WebAssembly/component-model#641 plus bytecodealliance/wasm-tools#2507.

@alexcrichton alexcrichton requested a review from dicej April 27, 2026 22:08
@github-actions github-actions Bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Apr 28, 2026
@github-actions
Copy link
Copy Markdown

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton alexcrichton marked this pull request as ready for review April 28, 2026 16:47
@alexcrichton alexcrichton requested review from a team as code owners April 28, 2026 16:47
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team April 28, 2026 16:47
@alexcrichton
Copy link
Copy Markdown
Member Author

alexcrichton commented Apr 28, 2026

This now pulls in an update-to wasm-tools and should be good to go modulo CI/review

This commit renames the previous `wasm_component_model_async_builtins` feature to
`wasm_component_model_more_async_builtins` and then moves synchronous
future/stream reads/writes behind this feature. This is inspired by
bytecodealliance#13212 and corresponds to
WebAssembly/component-model#641 plus bytecodealliance/wasm-tools#2507.
@alexcrichton alexcrichton enabled auto-merge April 28, 2026 18:31
@alexcrichton alexcrichton added this pull request to the merge queue Apr 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026
@alexcrichton alexcrichton enabled auto-merge April 28, 2026 20:05
@github-actions github-actions Bot added fuzzing Issues related to our fuzzing infrastructure wasmtime:c-api Issues pertaining to the C API. labels Apr 28, 2026
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants