fix(agent): await endExecution in onAgentLoopEnd to ensure cleanup completes#1832
Open
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Open
fix(agent): await endExecution in onAgentLoopEnd to ensure cleanup completes#1832Br1an67 wants to merge 1 commit intobytedance:mainfrom
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Conversation
In streaming mode, onAgentLoopEnd called endExecution() as fire-and-forget (.catch() without await), so the cleanup handler that sends the agent_run_end event could complete after the method returned. This caused the Web UI to never receive the termination signal, leaving it stuck in a spinning state. Properly await endExecution() to ensure the agent_run_end event is sent before the streaming promise chain completes. Closes bytedance#1061
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1061
In streaming mode,
onAgentLoopEndcalledendExecution()with.catch()(fire-and-forget) instead ofawait. This meant cleanup handlers—including the one that sends theagent_run_endevent—could complete after the method returned, causing the stream adapter to never receive the completion signal.Changes:
endExecution().catch(...)totry { await endExecution() } catchagent_run_endevent emission) completes beforeonAgentLoopEndreturnsChecklist