fix(shared-media-utils): use dynamic imports for ESM-only imagemin packages#1833
Open
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Open
fix(shared-media-utils): use dynamic imports for ESM-only imagemin packages#1833Br1an67 wants to merge 1 commit intobytedance:mainfrom
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Conversation
…ckages imagemin-mozjpeg, imagemin-webp, imagemin-pngquant, and imagemin v8+ are ESM-only packages that cannot be require()'d from CJS output. The shared-media-utils package builds to CJS format, causing ERR_REQUIRE_ESM at runtime. Replace static imports with dynamic import() calls which work in both CJS and ESM contexts. Closes bytedance#1700
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1700
The
imageminecosystem packages (v8+) are ESM-only, butshared-media-utilsbuilds to CJS, causingERR_REQUIRE_ESMat runtime. Staticimportstatements forimagemin,imagemin-mozjpeg,imagemin-pngquant, andimagemin-webpfail when the consuming code runs in a CJS context.Changes:
import()helper functions for all imagemin packagesgetPluginsForFormat()async (was sync) since plugins are now loaded dynamicallycompressToBuffer()to await the dynamic imagemin importThis allows the CJS build output to load ESM-only packages at runtime via dynamic import.
Checklist