fix(utils): prevent falsy value cache bypass in ShortCache - #1161
Open
MeiSiristhebest wants to merge 2 commits into
Open
fix(utils): prevent falsy value cache bypass in ShortCache#1161MeiSiristhebest wants to merge 2 commits into
MeiSiristhebest wants to merge 2 commits into
Conversation
MeiSiristhebest
requested review from
YuanHeDx,
dragooncjw,
louisyoungx,
luics,
sanmaopep and
xiamidaxia
as code owners
August 14, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1160
Motivation
In
createShortCache, truthiness evaluationif (cache)causes valid falsy cached values (false,0,"",null) to be bypassed on every subsequent call, repeatedly re-executing the computation function.Changes
hasCache: booleanflag to correctly preserve falsy cached primitives.clear()anddispose()onShortCache<T>for deterministic timer cleanup and resource teardown.Verification
false,0,"", andnullcaching behavior.