Skip to content

Update to Go 1.22 and stretchr/testify 1.9.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stone-z
Copy link

@stone-z stone-z commented Sep 26, 2024

I noticed the latest releases (all past 1.4.0) weren't listed in the Go package index (ref).

I'm honestly not sure if this is the cause of that issue, but since 1.13 is quite old I figured it was worth the update anyway.

@stone-z
Copy link
Author

stone-z commented Oct 7, 2024

Just for visibility, ping @bzick

@bzick
Copy link
Owner

bzick commented Oct 8, 2024

Thank you for MR. I agree that 1.13 is already outdated, but is it really worth updating straight to 1.23? Most of my projects can’t update to 1.23 and are still running on 1.20-1.22. I mean, 1.23 is still too recent. Maybe it’s worth considering a version that came out two years ago (suggestion)?

And what are the reasons for updating? (got it)

@bzick
Copy link
Owner

bzick commented Oct 8, 2024

And thank you that you notice what latest releases weren't listed in the Go package index 🙌

@bzick
Copy link
Owner

bzick commented Oct 8, 2024

About why latest releases weren't listed. My fault. I named versions wrang. e.g. I named 1.4.4 but I should have named v1.4.4. I created v1.4.5 and everything OK now.

@stone-z
Copy link
Author

stone-z commented Oct 8, 2024

Sure, Go 1.22 could work also. 1.21 will lose support in February, 1.22 would get updates until next August. I just went to 1.23 since it would be the longest supported. Let me know and I can change to 1.22 I updated the PR so it is Go 1.22 instead 🙂

@stone-z stone-z changed the title Update to Go 1.23 and stretchr/testify 1.9.0 Update to Go 1.22 and stretchr/testify 1.9.0 Oct 8, 2024
@n-peugnet
Copy link
Contributor

n-peugnet commented Jan 14, 2025

The go directive indicates "the minimum version of Go required to use this module" (see Go Modules Reference: go directive). There is no point in increasing it if not for using newer language features.

And this is also true for the require directive, which indicates "the minimum required version of a given module dependency" (see Go Modules Reference: require directive). Except if we are affected by a bug found in previous versions of testify or if we need newer features, I don't see a reason to increase this requirement.

The indirect dependencies can be easily added to go.mod by running go mod tidy (when targeting go 1.16 and above) without the need for updating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants