-
Notifications
You must be signed in to change notification settings - Fork 4
Fix insufficient commentUrlParamsRegex #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the fix! Could you enable the CI to run on your fork? Then if it's green I can merge it. |
I've attempted to do so here https://github.com/GiovanH/actions/runs/8106103842?check_suite_focus=true but I'm not super familiar with github actions so it doesn't look like the new code has actually taken effect yet |
On your fork repo, you need to enable github actions in the settings: https://github.com/GiovanH/fresh-bot |
c292740
to
42e4abc
Compare
👀 |
I'll double-check why the CI wasn't running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove console.debug and pull latets master to run the ci
} | ||
|
||
const commentParams = commentUrlParamsRegex.exec(subjectUrl); | ||
console.debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove theconsole.debug
Fixes #34