Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building .vsix file #11

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fixes for building .vsix file #11

merged 2 commits into from
Dec 26, 2024

Conversation

tonis2
Copy link
Contributor

@tonis2 tonis2 commented Dec 26, 2024

@pherrymason Let me know if you find any issues with below changes

I created some fixes to the extensions to make it work on my Linux machine.

Also edited the pop-up dialog message a bit, and used below messages, In my opinion it explains better what the actions do.

 "Download LSP binary",
 "Specify LSP binary path",

@pherrymason
Copy link
Contributor

Looks good to me 👍

@lerno lerno merged commit 7c6e5b6 into main Dec 26, 2024
@lerno
Copy link
Contributor

lerno commented Dec 26, 2024

Looks like this failed:

2024-12-26T19:48:30.3369930Z export NVM_DIR="$HOME/.nvm"
2024-12-26T19:48:30.3370574Z [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
2024-12-26T19:48:30.3371245Z [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
2024-12-26T19:48:30.5532179Z Now using system version of node: v18.20.5 (npm v10.8.2)
2024-12-26T19:48:30.9901850Z Downloading and installing node v22.12.0...
2024-12-26T19:48:31.1211550Z Downloading https://nodejs.org/dist/v22.12.0/node-v22.12.0-linux-x64.tar.xz...
2024-12-26T19:48:31.2452375Z 
2024-12-26T19:48:31.3463097Z ##########                                                                14.9%
2024-12-26T19:48:31.4191466Z ##############################################                            64.1%
2024-12-26T19:48:31.4192338Z ######################################################################## 100.0%
2024-12-26T19:48:31.4354932Z Computing checksum with sha256sum
2024-12-26T19:48:31.5605004Z Checksums matched!
2024-12-26T19:48:33.8418384Z Now using node v22.12.0 (npm v10.9.0)
2024-12-26T19:48:34.0919244Z Now using node v22.12.0 (npm v10.9.0)
2024-12-26T19:48:37.3258401Z 
2024-12-26T19:48:37.3259245Z added 73 packages, and audited 74 packages in 3s
2024-12-26T19:48:37.3260003Z 
2024-12-26T19:48:37.3260276Z 5 packages are looking for funding
2024-12-26T19:48:37.3260797Z   run `npm fund` for details
2024-12-26T19:48:37.3268666Z 
2024-12-26T19:48:37.3268907Z found 0 vulnerabilities
2024-12-26T19:48:37.4394260Z 
2024-12-26T19:48:37.4394705Z > [email protected] build
2024-12-26T19:48:37.4395451Z > node ./build_syntax.js && npm run esbuild-base -- --minify && vsce package
2024-12-26T19:48:37.4396137Z 
2024-12-26T19:48:37.5939148Z 
2024-12-26T19:48:37.5939822Z > [email protected] esbuild-base
2024-12-26T19:48:37.5940967Z > esbuild ./src/extension.js --bundle --outfile=dist/extension.js --external:vscode --format=cjs --platform=node --minify
2024-12-26T19:48:37.5942218Z 
2024-12-26T19:48:37.6716999Z 
2024-12-26T19:48:37.6717567Z   dist/extension.js  747.7kb
2024-12-26T19:48:37.6717970Z 
2024-12-26T19:48:37.6718459Z ⚡ Done in 69ms
2024-12-26T19:48:37.6785282Z sh: 1: vsce: not found
2024-12-26T19:48:37.6882346Z ##[error]Process completed with exit code 127.
2024-12-26T19:48:37.6946276Z Cleaning up orphan processes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants