Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install / Update automatically versions of LSP #3

Closed
wants to merge 0 commits into from

Conversation

pherrymason
Copy link
Contributor

@pherrymason pherrymason commented Sep 4, 2024

This PR brings two main features:

  1. On start, it will check for c3.lsp.path setting and if not defined, it will provide the user with multiple options to set it up: Use the PATH, set a custom path or Install it.

When selecting Install, the extension will download the binary for the current platform (if available) and install it inside the extension directory.

  1. It will periodically check for updates, allowing to update the LSP if a new version is found.

Note: I've been very much inspired by the zig vscode extension. I ignore if something needs to be done on the licensing side (mention them?)

@joshring
Copy link

joshring commented Sep 4, 2024

42K lines, that's so much code!

@pherrymason
Copy link
Contributor Author

It's because of the build final javascript code, which could be omited from the repo.

@pherrymason
Copy link
Contributor Author

Removed.

@lerno
Copy link
Contributor

lerno commented Nov 14, 2024

Ok, I merged the other one and now there seems to be conflicts?

@pherrymason
Copy link
Contributor Author

I will take a look, thanks for the notice

@pherrymason
Copy link
Contributor Author

pherrymason commented Dec 4, 2024

Looks like this automatically closed on rebasing my branch from main. I will reopen a new one: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants