fix(flash): Add support for querying hardware version on USB 3.0 ports #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubVanek
force-pushed
the
feature/getversion-on-usb30
branch
3 times, most recently
from
3f57f89 to
b10617d
Compare
|
This is now tested and known to work. On USB 3.0, this is now returned |
JakubVanek
force-pushed
the
feature/getversion-on-usb30
branch
from
b10617d to
1efa4b7
Compare
As noted in the linked commit (coming from pybricks/pybricksdev#98), the EEPROM version can still be read even when the brick is plugged into a USB 3.0 port.
JakubVanek
force-pushed
the
feature/getversion-on-usb30
branch
from
1efa4b7 to
0f7fc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the linked commit (coming from pybricks/pybricksdev#98), the hardware version can still be read even when the brick is plugged into a USB 3.0 port.
Unforunately, the CRC packets likely cannot be salvaged this way - the CRC request is longer than the CRC response and so the CRC value is overwritten inside the brick.EDIT: It seems that CRC replies are not corrupted at all.I have not yet tested this code myself, so I have created this as a draft PR for now.