Skip to content

Conversation

faizanakram99
Copy link

Twig_* will be removed in v2, replaced all such usages with FCQN which are both twig 1 and 2 compatible

some whitespace changes
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
- 5.5
- 5.6
- hhvm
- '7.2'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 7.2 a must?

Copy link
Author

@faizanakram99 faizanakram99 Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, something was wrong with travis build and it was complaining about missing packages.
Support for PHP 7.1 will end in December 2019 tho

"php": ">=5.3.0",
"corneltek/codegen": "^2",
"twig/twig": "^1"
"php": ">=7.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break the dependent packages

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will try to use an old php version, is 7.1 ok? or should it be 5.x ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants