-
Notifications
You must be signed in to change notification settings - Fork 3
Twig 2 compatibility and updated composer packages #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
updating own fork
some whitespace changes
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
Signed-off-by: Faizan Akram <[email protected]>
- 5.5 | ||
- 5.6 | ||
- hhvm | ||
- '7.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 7.2 a must?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, something was wrong with travis build and it was complaining about missing packages.
Support for PHP 7.1 will end in December 2019 tho
"php": ">=5.3.0", | ||
"corneltek/codegen": "^2", | ||
"twig/twig": "^1" | ||
"php": ">=7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might break the dependent packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, will try to use an old php version, is 7.1 ok? or should it be 5.x ?
Twig_* will be removed in v2, replaced all such usages with FCQN which are both twig 1 and 2 compatible