Skip to content

fix: non-exhaustive pattern in is_connection_open on old Rust versions #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: non-exhaustive pattern in is_connection_open on old Rust versions #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b059f8
fix: use _ instead of range pattern in match
5t0n3 Sep 11, 2024
f8c99e9
chore: update changelog
5t0n3 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

(no changes yet)
### tacacs-plus

#### Fixed

- Use `_` instead of range pattern to prevent breakage on older Rust versions (<=1.74)

## [0.3.1] - 2024-09-11

Expand Down
2 changes: 1 addition & 1 deletion tacacs-plus/src/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ where

// if there's data still available, the connection is still open, although
// this shouldn't happen in the context of TACACS+
Ok(1..) => Ok(true),
Ok(_) => Ok(true),
},

// nothing ready to read -> connection is still open
Expand Down