Uniswap fix#42
Open
rogervs wants to merge 6 commits into
Open
Conversation
rogervs
commented
Mar 15, 2021
rogervs
commented
Contributor
- Update file names referenced in notebook to match those being used in this version
- Added detail on where to obtain pickle file
- Add ETHDAI_EDA_and_ETL.ipynb from older version of repo ( @markusbkoch please check if this is the correct notebook )
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Thanks, Roger. I updated the etl notebook in kaggle a few weeks ago. Are
you able to download the current version from kaggle? If so could you
please replace the one in this PR with it?
…On Mon, Mar 15, 2021, 19:45 review-notebook-app[bot] < ***@***.***> wrote:
Check out this pull request on [image: ReviewNB]
<https://app.reviewnb.com/cadCAD-org/demos/pull/42>
See visual diffs & provide feedback on Jupyter Notebooks.
------------------------------
*Powered by ReviewNB <https://www.reviewnb.com/?utm_source=gh>*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKABI5QX56NOK4RUFNXP33TD2EYTANCNFSM4ZHMPNCA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.