Streamline DG Discretization Interface #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreue16
changed the title
jbreue16
force-pushed
the
chore/dg_interface
branch
3 times, most recently
from
e9f5242 to
a15e140
Compare
jbreue16
changed the title
jbreue16
commented
Dec 18, 2023
schmoelder
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Hey @jbreue16, I really like it. Maybe in the beginning add a little bit more information on what FV and DG actually are.
jbreue16
added a commit
that referenced
this pull request
Jan 17, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
Jan 28, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function
jbreue16
added a commit
that referenced
this pull request
Feb 20, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function
jbreue16
added a commit
that referenced
this pull request
Mar 11, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function
jbreue16
added a commit
that referenced
this pull request
Apr 2, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177)
jbreue16
added a commit
that referenced
this pull request
Apr 17, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177)
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Apr 22, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
May 5, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 8, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
May 23, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 28, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
May 31, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
to jbreue16/CADET
that referenced
this pull request
Jun 3, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to cadet#177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
jbreue16
added a commit
that referenced
this pull request
Jun 18, 2024
* Change DG unit interfaces from unit_type suffix to discretization specification * Infer DG disc from NCOL and NPAR and set default values * Rename DG element fields to nelem and par_nelem * Fix test interfaces, i.e. adjust to createUnitOperation function * Improve parameter interface DG units (according to #177) Co-authored-by: sleweke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #144:
We have decided to read the discretization type from a new field
discretization/spatial_method. Specification of this field is optional for FV to avoid a breaking change on the main branch. Old scripts using CADET-DG will be broken since the unit_type field does not allow inputs with the "_DG" suffix anymore; instead the discretization/discretization_scheme must be specified (currently as "DG").TODO:
unit_typefield to a field in thediscretizationgroup