Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove years from copyright notice in files #278

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Aug 20, 2024

Fixes #170

To-do

  • Add years to license (similar to how it's done in curl)?

@schmoelder schmoelder added this to the v5.0.0 "CADET-Core" milestone Aug 20, 2024
@schmoelder schmoelder force-pushed the docs/remove_copyright branch from 5e469a4 to 13386d6 Compare August 22, 2024 07:55
@schmoelder schmoelder requested a review from jbreue16 August 22, 2024 07:55
LICENSE.txt Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
// =============================================================================
// CADET - The Chromatography Analysis and Design Toolkit
//
// Copyright © 2008-2024: The CADET Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or was this supposed to be the only source file where its still included? I dont see why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I guess this was a mistake. I used sed to edit all files maybe there was some hickup.

@schmoelder
Copy link
Contributor Author

By the way, I see that you often seem to have some trailing whites pace in your source. I'm sure there is an option in your IDE that automatically removes that "on save".

@schmoelder schmoelder force-pushed the docs/remove_copyright branch 2 times, most recently from 941f679 to 40b6610 Compare August 23, 2024 07:59
@schmoelder schmoelder force-pushed the docs/remove_copyright branch from 40b6610 to fc17580 Compare August 23, 2024 11:54
@schmoelder schmoelder merged commit f76452a into master Aug 23, 2024
4 checks passed
@schmoelder schmoelder deleted the docs/remove_copyright branch August 23, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove years from copyright notice in files
2 participants