-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/rapid equilibrium reactions for CSTR #324
base: master
Are you sure you want to change the base?
Conversation
if you write the keyword to close the issue right in front of the corresponding issue, it will automatically be closed when the PR is merged. I.e. writing "fixes" instead of "resolves therefore" in the PR description .. maybe "resolves" also works |
@@ -26,6 +26,9 @@ | |||
#include <string> | |||
#include <vector> | |||
|
|||
#include <Eigen/Dense> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its time to make Eigen obligatory for CADET.
Currently, Eigen is only installed when the ENABLE_DG
flag is set to ON (which is the default)
So when you are using Eigen in another submodule, the build will fail when ENABLE_DG
is OFF
We can either make Eigen obligatory for CADET or you also guard the rapid-equilibrium reaction code with compile time flags checking for Eigen.
You can see this e.g. under /src/libcadet/CMakeLists.txt
where the DG units are only included if the flag is ON
This is only relevant for the merge into master, so for now you can also just set this as the last todo in your todo list
1765bfd
to
6a4367e
Compare
consisitent intitalisation does not work for singualr jacobian
Fixes #20.
This PR will add the feature to set reactions into a rapid equilibrium in liquid phase for the CSTR
Workflow:
More information about the algorithm are available under the forum post about reactions in rapid equilibrium