Change default for USE_MODIFIED_NEWTON to true
#478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen in the cadet-julia benchmark paper, that the modified Newton method is oftentimes more efficient when combined with the (linear) DG discretization, while its less efficient for FV.
When changing the default to modified newton, Ive observed that some tests loose accuracy.. maybe its not a good idea to make this the new default after all, especially considering non-linear bindings and the future development of non-linear DG.
I think we should choose stability/accuracy over efficiency for now and use this draft here for more rigorous benchmarking.
See #221