Skip to content

fix_calc_max_steps #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ssukriti wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix_calc_max_steps #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6bfb01
calc_max_steps
Ssukriti Dec 11, 2023
6779595
formatting
Ssukriti Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion caikit_nlp/modules/text_generation/peft_prompt_tuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,9 @@ def train(
num_epochs,
cls.RANDOM_SEED,
learning_rate,
max_steps=infer_max_steps(num_epochs, batch_size, training_dataset),
max_steps=infer_max_steps(
num_epochs, batch_size, accumulate_steps, training_dataset
),
silence_progress_bars=silence_progress_bars,
accumulate_steps=accumulate_steps,
# NOTE: following can override above arguments in order
Expand Down
2 changes: 2 additions & 0 deletions caikit_nlp/toolkit/text_generation/training_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,10 @@ def launch_training(
def infer_max_steps(
num_epochs: int,
batch_size: int,
ga_steps: int,
training_dataset: Union[Dataset, TransformersIterableDataset],
):
batch_size = batch_size * ga_steps
# Calculate the number of samples that we have
if isinstance(training_dataset, Dataset):
data_len = len(training_dataset)
Expand Down