Skip to content

Fix CVE's for caikit-nlp #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpancham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CVE's for caikit-nlp #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = [
"setuptools>=60",
"setuptools>=78.1.1",
"setuptools-scm>=8.0"]

[project]
Expand Down Expand Up @@ -29,7 +29,7 @@ dependencies = [
"scipy>=1.10.0",
"sentence-transformers>=3.4.0,<3.5.0",
"tokenizers>=0.20.0",
"torch>=2.3.1,<2.9.0",
"torch>=2.8.0",
Copy link
Contributor

@gabe-l-hart gabe-l-hart Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we try to avoid requiring a lower bound like this since it disallows users that are stuck on older versions for one reason or another. I think the correct thing to do here is to simply remove the upper bound:

Suggested change
"torch>=2.8.0",
"torch>=2.3.1",

Copy link
Collaborator

@alex-jw-brooks alex-jw-brooks Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpancham @gabe-l-hart is this change actually needed, or do we just need to explicitly build an image somewhere with torch 2.8?

I followed the CVEs, and it seems to be patched in 2.8+, but that should already be compatible with things as they are, right?
GHSA-887c-mr87-cxwp
GHSA-3749-ghw9-m3mg

Copy link
Author

@rpancham rpancham Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my understanding, the CVE fix for PyTorch (GHSA-887c-mr87-cxwp) is included in torch 2.8.0+, so ensuring our image/tests use a patched version is sufficient from a security perspective. Because of that, we don’t need to keep the upper bound in pyproject.toml.

If the goal is to maintain compatibility with older torch versions, I can update the dependency to:

"torch>=2.3.1",

and remove the upper bound as suggested.
Please let me know if you'd like me to make this change — I can update the PR and sign off accordingly.

Copy link
Contributor

@gabe-l-hart gabe-l-hart Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's go ahead and simply remove the upper bound. If CI passes, this will be a good additional piece of flexibility for users and will enable forward-compatible CVE fixes.

Copy link

@pasalubong pasalubong Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpancham Have you had a chance to circle back on this change?

"tqdm>=4.67.0",
"transformers>=4.48.3,<4.50.0",
"peft==0.14.0",
Expand Down
Loading