Skip to content

mrtnetwork: fix empty segwit deserialization #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: cake-update-v9
Choose a base branch
from
Open

mrtnetwork: fix empty segwit deserialization #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions lib/src/bitcoin/script/transaction.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class BtcTransaction {
}
cursor += 2;
}
final vi = IntUtils.decodeVarint(rawtx.sublist(cursor, cursor + 9));
final vi = IntUtils.decodeVarint(rawtx.sublist(cursor));
cursor += vi.item2;

bool canReplaceByFee = false;
Expand All @@ -114,7 +114,7 @@ class BtcTransaction {
}

List<TxOutput> outputs = [];
final viOut = IntUtils.decodeVarint(rawtx.sublist(cursor, cursor + 9));
final viOut = IntUtils.decodeVarint(rawtx.sublist(cursor));
cursor += viOut.item2;
for (int index = 0; index < viOut.item1; index++) {
final inp = TxOutput.fromRaw(raw: raw, hasSegwit: hasSegwit, cursor: cursor);
Expand All @@ -123,32 +123,37 @@ class BtcTransaction {
}
List<TxWitnessInput> witnesses = [];
if (hasSegwit) {
for (int n = 0; n < inputs.length; n++) {
final input = inputs[n];
if (input.scriptSig.script.isNotEmpty) continue;

final wVi = IntUtils.decodeVarint(rawtx.sublist(cursor, cursor + 9));
cursor += wVi.item2;
List<String> witnessesTmp = [];
for (int n = 0; n < wVi.item1; n++) {
List<int> witness = <int>[];
final wtVi = IntUtils.decodeVarint(rawtx.sublist(cursor, cursor + 9));
if (wtVi.item1 != 0) {
witness = rawtx.sublist(cursor + wtVi.item2, cursor + wtVi.item1 + wtVi.item2);
}
if (cursor + 4 < rawtx.length) {
// in this case the tx contains wintness data.
for (int n = 0; n < inputs.length; n++) {
final wVi = IntUtils.decodeVarint(rawtx.sublist(cursor));
cursor += wVi.item2;
List<String> witnessesTmp = [];
for (int n = 0; n < wVi.item1; n++) {
List<int> witness = <int>[];
final wtVi = IntUtils.decodeVarint(rawtx.sublist(cursor));
if (wtVi.item1 != 0) {
witness = rawtx.sublist(
cursor + wtVi.item2, cursor + wtVi.item1 + wtVi.item2);
}
cursor += wtVi.item1 + wtVi.item2;
witnessesTmp.add(BytesUtils.toHexString(witness));
}

witnesses.add(TxWitnessInput(stack: witnessesTmp));
}
}
}
List<int>? mwebBytes;
if (hasMweb) {
mwebBytes = rawtx.sublist(cursor, rawtx.length - 4);
}
cursor = rawtx.length - 4;
List<int> lock = rawtx.sublist(cursor, cursor + 4);
List<int>? lock;
if ((rawtx.length - cursor) >= 4) {
lock = rawtx.sublist(cursor, cursor + 4);
}
print("lock $lock");
return BtcTransaction(
inputs: inputs,
outputs: outputs,
Expand Down