Skip to content

Add test case to show collation issue in MysqlAdapter::createTable() #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishanvyas22 wants to merge 1 commit into
base: 4.x
Choose a base branch
from
+24 −0
Open

Add test case to show collation issue in MysqlAdapter::createTable() #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/TestCase/Db/Adapter/MysqlAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use Migrations\Db\Table\Column;
use Migrations\Db\Table\ForeignKey;
use Migrations\Db\Table\Index;
use Migrations\Db\Table\Table as TableMetadata;
use PDO;
use PDOException;
use PHPUnit\Framework\Attributes\DataProvider;
Expand Down Expand Up @@ -166,6 +167,29 @@ public function testCreateTable()
$this->assertFalse($columns[0]->isSigned());
}

public function testCreateTableMethod()
{
$table = new TableMetadata('custom_collation', ['id' => false, 'primary_key' => ['id'], 'collation' => 'utf8mb4_unicode_ci']);

$columnId = new Column();
$columnId
->setName('id')
->setType('uuid')
->setCollation('ascii_general_ci')
->setEncoding('ascii');
$columnName = new Column();
$columnName
->setName('name')
->setType('text');
$columns = [$columnId, $columnName];

$this->adapter->createTable($table, $columns);

$rows = $this->adapter->fetchAll('SHOW FULL COLUMNS FROM custom_collation');
$this->assertEquals('ascii_general_ci', $rows[0]['Collation']); // specified collation is set
$this->assertEquals('utf8mb4_unicode_ci', $rows[1]['Collation']); // if not specified uses table's collation
}

public function testCreateTableWithComment()
{
$tableComment = 'Table comment';
Expand Down
Loading