Fix column collation not applied for uuid type#1025
Open
dereuromark wants to merge 1 commit into4.xfrom
Open
Conversation
The MysqlSchemaDialect in cakephp/database only adds COLLATE for text, char, and string types. Since uuid columns generate CHAR(36) but use the 'uuid' type identifier, collation was being ignored. This fix converts uuid to char(36) in mapColumnData() so the dialect properly handles the collation. Fixes the issue reported in #1020.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uuidtype columns increateTable()uuidtocharwith length 36 inmapColumnData()so the dialect properly handles collationThis is a workaround for the issue reported in #1020. The root cause is that
MysqlSchemaDialect::columnDefinitionSql()in cakephp/database only addsCOLLATEfortext,char, andstringtypes. Sinceuuidcolumns generateCHAR(36)SQL but use theuuidtype identifier, collation was being ignored.A proper fix will be proposed to cakephp/cakephp to add
uuidto the$hasCollatearray in the dialect.Closes #1020