Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dry run improvements for v2 #19196

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Feb 8, 2025

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • (N/A) I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • (N/A) I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

can be tested in the examples app for platform, we would need to do is add cal.isBookingDryRun=true in routingFormUrl and then log out the query for GetAvailableSlotsInput in v2 slots controller

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Feb 8, 2025
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:35am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:35am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:35am

@Ryukemeister Ryukemeister marked this pull request as ready for review February 10, 2025 12:21
@Ryukemeister Ryukemeister requested a review from a team as a code owner February 10, 2025 12:21
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Feb 10, 2025
@Ryukemeister
Copy link
Contributor Author

only merge this after #18865, also we would need to bump platform libraries version after this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants