Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use UserCreationService when creating new owner for new orgs #19201

Open
wants to merge 8 commits into
base: sys-admin-use-usercreationservice
Choose a base branch
from

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Feb 9, 2025

Stacked on #19200

What does this PR do?

  • Adds WEBAPP_NEW_ORG and API_V2_NEW_ORG to CreationSource
  • When creating a new org and the owner doesn't exist, use the UserCreationService

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link
Contributor

github-actions bot commented Feb 9, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Create createUser method in userCreationService". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@joeauyeung joeauyeung changed the base branch from main to sys-admin-use-usercreationservice February 9, 2025 03:20
@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 9, 2025
@joeauyeung joeauyeung changed the title Create createUser method in userCreationService refactor: Create createUser method in userCreationService Feb 9, 2025
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:28am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:28am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:28am

@joeauyeung joeauyeung changed the title refactor: Create createUser method in userCreationService refactor: Use UserCreationService when creating new users for new orgs Feb 9, 2025
@joeauyeung joeauyeung changed the title refactor: Use UserCreationService when creating new users for new orgs refactor: Use UserCreationService when creating new owner for new orgs Feb 9, 2025
@github-actions github-actions bot added the ❗️ migrations contains migration files label Feb 9, 2025
@joeauyeung joeauyeung marked this pull request as ready for review February 10, 2025 03:33
@joeauyeung joeauyeung requested a review from a team as a code owner February 10, 2025 03:33
@graphite-app graphite-app bot requested a review from a team February 10, 2025 03:33
@dosubot dosubot bot added organizations area: organizations, orgs 💻 refactor labels Feb 10, 2025
Copy link

graphite-app bot commented Feb 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ migrations contains migration files organizations area: organizations, orgs 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants