Fix prevent false positive is valid #131
Conversation
| @@ -1,4 +1,6 @@ | |||
| import { expect, fixture, html } from '@open-wc/testing'; | |||
| import '@material/web/radio/radio.js' | |||
There was a problem hiding this comment.
drive-by comment, I wouldn't recommend importing a final implementation of a component, there's a lot going on in MWC's radio that would make this difficult to reliably test.
Instead, I'd try to see what <md-radio> is doing that isn't working and create a minimal reproduction class like TestInput.
There was a problem hiding this comment.
tahnks @asyncliz you are rigth - however, my own bandwidth is too limited at the moment to dive deeper into radio internals (and no webkit available to play around with devtools).
There was a problem hiding this comment.
Sorry it's been so long on this. Burn out is real and I'm trying to keep my head mostly in my current-employer's code base (which is React-based) to protect my own sanity. I definitely agree with Liz here that I'm happy to merge this but I don't want MWC radio as a dev dependency. If you can replicate the issue without MWC, I'll get this merged in.
christophe-g
force-pushed
the
fix-prevent-false-positive-isValid
branch
from
e3b61ce to
a2e203a
Compare
This is to allow run playwright webkit on linux Mint
This is to test scenario like material-components/material-web#5626 (comment)
christophe-g
force-pushed
the
fix-prevent-false-positive-isValid
branch
from
a2e203a to
18145e1
Compare
|
any updates? |
4 participants
Fix material-components/material-web#5626 (comment)