Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate empty cache file by filesize #124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvenghaus
Copy link

When the cache is enabled and the getRows method throws an exception, an empty database file is created. This file passes the exists and mtime checks and results in an error when the file is used the next time. You have do manually delete this file to fix it.

@inmanturbo
Copy link
Contributor

Nice! This is something I run into often. Particular if there is a timeout when the cache is being created the first time. I time myself having to "warm up" an app that I maintain, to ensure the cache file filled successfully and the sushi model is in an operable state. I tried to do it in the queue, it doesn't always workout. If someone tries visit the page at just the wrong moment when the cache is rebuilding it gets stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants