Skip to content

fix(ios): v7 swipe to go back gestures with react navigation #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2023
Merged

fix(ios): v7 swipe to go back gestures with react navigation #712

merged 5 commits into from
Mar 29, 2023

Conversation

intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Mar 28, 2023 •
edited
Loading

Summary

Resolves - #709

  • Adds swipe-to-go-back from the edge and fullScreenGestureEnabled support in scroll view implementation of pager view.
  • This has a much cleaner approach thanks to the new scroll view based implementation, we don't need an extra pan gesture.

Test Plan

Test example and fabric example with native stack and fullScreenGestureEnabled

What's required for testing (prerequisites)?

Run yarn install and pod install in example and fabric example

What are the steps to reproduce (after prerequisites)?

  • Test if swipe to go back gesture from edge works
  • Add fullScreenGestureEnabled and test if full screen swipe from the first page pops the screen.

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@intergalacticspacehighway
Copy link
Contributor Author

open to changing the name of RNCPageScrollView since it's not an actual React Native Component. Couldn't decide so kept this for now 😅. Maybe just PagerViewScrollView?

okwasniewski
okwasniewski reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🎉 I'm leaving two minor comments and I think we will be ready to merge.

@okwasniewski okwasniewski merged commit a3e4dd9 into callstack:next Mar 29, 2023
@intergalacticspacehighway intergalacticspacehighway mentioned this pull request Apr 4, 2023
Open
@igorbej igorbej mentioned this pull request Nov 30, 2023
Merged
3 tasks
igorbej added a commit that referenced this pull request Dec 14, 2023
@igorbej
chore(ios): bring back (currently unused) code related to #712 and #705
0212f97
troZee pushed a commit that referenced this pull request Dec 21, 2023
@igorbej
feat(iOS): Add a useLegacy flag to switch between the old/new iOS i…
c8cc208 
…mplementation (#783)

* wip: unsuspicious changes

* wip: unsuspicious changes v2

* FABRIC NEW IMPL -> OLD IMPL

* wip: bring back useLegacy on the RN side

* wip: bring back duplicate types to fix codegen issues

* wip: remove #705 related code for now

* wip: old/new impl division first draft

* wip: old/new impl division continued

* wip: old/new impl v3

* wip: add a `LEGACY_` prefix to all legacy implementation-related symbols

* wip: fix styles for new implementation on Fabric

* wip: move old/new impl into separate folders

* wip: fix old impl fabric symbol names

* wip: xcode changes

* wip: clean up & unify the naming convention

* wip: fix linter issues

* wip: fix styles for new implementation on Paper

* wip: make Fabric example run on another port by default to make it possible to run both examples in parallel

* wip: implement an abstraction over native commands invocations to reduce branching

* refactor: remove the unnecessary value for boolean props

* fix: bump react-native-safe-area-context to a Fabric-enabled version

* feat: bring back & adjust the `bootstrap-fabric` script

* feat: adjust the home screen title depending on the used architecture

* chore: update example/Podfile.lock

* chore: update an Xcode project file after building

* ci: make next branch events trigger ios/android build workflows

* chore: remove commented-out code related to #705 for now

* chore: add legacy implementation explanation comment

* wip: Android fixes

* fix: unnecessary comma in MainActivity.java

* feat: readme makeover

* chore: bump react-native-screens & react-native-gesture-handler in example

* refactor(android): extract module name to shared variable, add comment for context

* chore: remove unnecessary yarn.lock deps

* chore(ios): bring back removed build flags

* chore(ios): remove unnecessary concurrentRootEnabled method

According to React Native Upgrade Helper, this method is to be removed when updating to RN 0.72:
https://react-native-community.github.io/upgrade-helper/?from=0.71.14&to=0.72.0#RnDiffApp-ios-RnDiffApp-AppDelegate.mm

* fix(android): adjust incorrect param type on Fabric

* chore: remove unnecessary tsconfig.json comment

* chore(ios): bring back (currently unused) code related to #712 and #705
troZee added a commit that referenced this pull request Mar 31, 2024
@troZee @krozniata
@okwasniewski @intergalacticspacehighway @ku8ar @igorbej
merge next to master (#817)
280c3a3 
* feat(iOS): change Fabric implementation to UIScrollView (#672)

* feat(iOS): change Fabric implementation to UIScrollView

* fix: fix offset values in vertical orientation

* feat: add initialPage props support

* feat: add RTL language support

* feat: add pageMargin prop support

* fix: fix typescript error

* feat: remove React.cloneElement

* feat(ios): add getPageOffset method

* fix: fix styles in old example

* fix: behavior on page remove

* chore: add GH actions (#680)

Co-authored-by: Piotr Trocki <[email protected]>

* feat(iOS): rewrite old arch to use UIScrollView (#681)

* feat: rewrite old arch to use UIScrollView

* feat: update example styles

* fix: sending event on scrollViewDidEndDecelerating

* feat: properly calculate width using orientation

* fix: change way of disabing scroll

* feat: rename to RNCPagerView

* fix: removing last page

* fix: remove unused properties, set animated

* chore: update release script

* Release 7.0.0-rc.0

* wip

* wip

* fabric example

* nit: comment

* make init consistent

* fix: multiple updates of frame and contentSize

* feat: add button to quickly switch layout direction

* sync with master (#756)

Co-authored-by: Piotr Trocki <[email protected]>

* chore: upgrade RN (paper example)

* chore: upgrade rn & fix issues (fabric example)

* chore: bump versions in package.json

* chore: fix eslint issue

* chore: exclude example from tsc

* feat(next): remove fabric example

* chore: update README

* fix broken overdrag on notch (#787)

Co-authored-by: Kuba Juszczyk <[email protected]>

* feat(iOS): Add a `useLegacy` flag to switch between the old/new iOS implementation (#783)

* wip: unsuspicious changes

* wip: unsuspicious changes v2

* FABRIC NEW IMPL -> OLD IMPL

* wip: bring back useLegacy on the RN side

* wip: bring back duplicate types to fix codegen issues

* wip: remove #705 related code for now

* wip: old/new impl division first draft

* wip: old/new impl division continued

* wip: old/new impl v3

* wip: add a `LEGACY_` prefix to all legacy implementation-related symbols

* wip: fix styles for new implementation on Fabric

* wip: move old/new impl into separate folders

* wip: fix old impl fabric symbol names

* wip: xcode changes

* wip: clean up & unify the naming convention

* wip: fix linter issues

* wip: fix styles for new implementation on Paper

* wip: make Fabric example run on another port by default to make it possible to run both examples in parallel

* wip: implement an abstraction over native commands invocations to reduce branching

* refactor: remove the unnecessary value for boolean props

* fix: bump react-native-safe-area-context to a Fabric-enabled version

* feat: bring back & adjust the `bootstrap-fabric` script

* feat: adjust the home screen title depending on the used architecture

* chore: update example/Podfile.lock

* chore: update an Xcode project file after building

* ci: make next branch events trigger ios/android build workflows

* chore: remove commented-out code related to #705 for now

* chore: add legacy implementation explanation comment

* wip: Android fixes

* fix: unnecessary comma in MainActivity.java

* feat: readme makeover

* chore: bump react-native-screens & react-native-gesture-handler in example

* refactor(android): extract module name to shared variable, add comment for context

* chore: remove unnecessary yarn.lock deps

* chore(ios): bring back removed build flags

* chore(ios): remove unnecessary concurrentRootEnabled method

According to React Native Upgrade Helper, this method is to be removed when updating to RN 0.72:
https://react-native-community.github.io/upgrade-helper/?from=0.71.14&to=0.72.0#RnDiffApp-ios-RnDiffApp-AppDelegate.mm

* fix(android): adjust incorrect param type on Fabric

* chore: remove unnecessary tsconfig.json comment

* chore(ios): bring back (currently unused) code related to #712 and #705

* Release 7.0.0-rc.1

* fix(ios): fix freezing when navigating to same index (#804)

* Release 7.0.0-rc.2

* fix iOS issue

* Change Legacy basic example into the next basic example

* revert documentatation

---------

Co-authored-by: Kacper Rożniata <[email protected]>
Co-authored-by: Piotr Trocki <[email protected]>
Co-authored-by: Oskar Kwaśniewski <[email protected]>
Co-authored-by: Nishan <[email protected]>
Co-authored-by: Kuba Juszczyk <[email protected]>
Co-authored-by: Kuba Juszczyk <[email protected]>
Co-authored-by: Igor Bejnarowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okwasniewski okwasniewski okwasniewski approved these changes

@krozniata krozniata krozniata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intergalacticspacehighway @okwasniewski @krozniata