Skip to content

feat: improve ferric build #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

dougg0k
Copy link
Contributor

@dougg0k dougg0k commented Jul 25, 2025

Copy link

changeset-bot bot commented Jul 25, 2025

🦋 Changeset detected

Latest commit: 263a1f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ferric-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougg0k dougg0k mentioned this pull request Jul 25, 2025
3 tasks
@dougg0k dougg0k closed this Jul 25, 2025
@dougg0k dougg0k reopened this Jul 25, 2025
@dougg0k dougg0k marked this pull request as ready for review July 25, 2025 20:04
@kraenhansen
Copy link
Collaborator

kraenhansen commented Jul 25, 2025

Until the formatter PR has been sorted out, I'd like for you to clean things up and leave out changes to any lines which are unrelated to the change you're proposing. (I hope to get the formatter situation resolved relatively soon 🤞)

@dougg0k dougg0k mentioned this pull request Jul 26, 2025
@kraenhansen
Copy link
Collaborator

kraenhansen commented Jul 26, 2025

I'm currently vacationing (you probably didn't notice my status, which is fine - but now you know). Please also be mindful that we have other priorities that we're working towards, which this is detracting attention from.

I'm checking my notifications regularly and there's no need to at-mention to get attention - you have it and I'll get to your suggestions and release those when I'm available to handle any issues that may arise from that.

As to your suggested changes:

  • there's 100+ lines with changes not related to the core of the issue you're solving
  • you're not providing a changeset
  • you're addressing multiple improvements in a single PR and one (storing output in dist) that doesn't have an issue associated, hence we didn't discuss. I'm honestly not sure if that's what we want to do, so let's discuss that on an issue describing the problem you're trying to solve first.

I need you to rectify all of the above before I consider the PR ready.

@kraenhansen kraenhansen added Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) labels Jul 26, 2025
@dougg0k
Copy link
Contributor Author

dougg0k commented Jul 26, 2025

I didnt, github should make that more visible. Sure.

  • It should be fine now (after prettier was added), just ignore the imports sorting.
  • My bad, added.
  • Before output files were mixed with source code of the library, so hence why dist/.

@dougg0k
Copy link
Contributor Author

dougg0k commented Aug 9, 2025

Is this or any other PR I made, getting merged? @kraenhansen


I did a merge branch main, and this error are showing https://github.com/callstackincubator/react-native-node-api/actions/runs/16850054592/job/47734889170?pr=205

I tried changin to import.meta.dirname, but it complains saying it will output to a commonjs module. What is the suggestion to fix?

It's the same issue on all 3 PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants