-
Notifications
You must be signed in to change notification settings - Fork 3
feat: improve ferric build #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 263a1f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Until the formatter PR has been sorted out, I'd like for you to clean things up and leave out changes to any lines which are unrelated to the change you're proposing. (I hope to get the formatter situation resolved relatively soon 🤞) |
I'm currently vacationing (you probably didn't notice my status, which is fine - but now you know). Please also be mindful that we have other priorities that we're working towards, which this is detracting attention from. I'm checking my notifications regularly and there's no need to at-mention to get attention - you have it and I'll get to your suggestions and release those when I'm available to handle any issues that may arise from that. As to your suggested changes:
I need you to rectify all of the above before I consider the PR ready. |
I didnt, github should make that more visible. Sure.
|
Is this or any other PR I made, getting merged? @kraenhansen I did a merge branch main, and this error are showing https://github.com/callstackincubator/react-native-node-api/actions/runs/16850054592/job/47734889170?pr=205 I tried changin to import.meta.dirname, but it complains saying it will output to a commonjs module. What is the suggestion to fix? It's the same issue on all 3 PRs. |
path
as arg to build project. Add path support in ferric-cli #195dist
folder.