Skip to content

Add rollup-plugin-commonjs compatibility note in Readme's footer. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add rollup-plugin-commonjs compatibility note in Readme's footer. #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,6 @@ export default timeout$1;
```

With that top piece only showing up once no matter how many times global was used.

**NOTE: Compatibility between `rollup-plugin-node-globals` and `rollup-plugin-commonjs`**
If you are using `rollup-plugin-commonjs`, make sure that `rollup-plugin-commonjs` comes before `rollup-plugin-node-globals`, otherwise `rollup-plugin-commonjs` will generate wrong imports and `ReferenceError`s may arise in your final bundle.