Open
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
KevScarr
approved these changes
Feb 23, 2026
KevScarr
left a comment
There was a problem hiding this comment.
All happy - as per review call 422 SERVICE_NOT_APPLICABLE added to cater for mismatch on phoneNumber and idDocument.
KevScarr
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR manages a simplification for some error scenarios:
422 -CUSTOMER_INSIGHTS.ID_DOCUMENT_REQUIRED422 - CUSTOMER_INSIGHTS.INVALID_IDENTIFIERSBoth scenarios are covered by
422 - SERVICE_NOT_APPLICABLEexceptionRegarding tests, the following ones are updated accordingly:
@retrieve_scoring_422.02_identifiers_mismatch
@retrieve_scoring_422.07_id_document_required_three_legged
@retrieve_scoring_422.08_id_document_required_two_legged
@retrieve_scoring_422.09_id_document_required_three_legged_with_scoring_type
@retrieve_scoring_422.10_id_document_required_two_legged_with_scoring_type
Taking advantage some clarifications are provided for tests:
@retrieve_scoring_C02.01_phone_number_not_schema_compliant
@retrieve_scoring_404.01_idDocument_not_found
Which issue(s) this PR fixes:
Fixes #59
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.