-
Notifications
You must be signed in to change notification settings - Fork 51
Initialize EAM /appinstances callback #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
travishepworth
wants to merge
11
commits into
camaraproject:main
Choose a base branch
from
travishepworth:EAM-Callback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0fceb46
Initialize EAM /appinstances callback
travishepworth 2bd31ab
Commit for EasyCLA
travishepworth faa7613
Update callback to return full object
travishepworth ddef274
Merge branch 'main' into EAM-Callback
travishepworth 8f1b244
Align towards commonalities and add deployment callback
travishepworth d803019
Align callbacks as a subscription to follow commonalities
travishepworth 09be1ff
Remove unused notificationSink
travishepworth 9af3846
Merge branch 'camaraproject:main' into EAM-Callback
travishepworth 3713abe
Remove messaging protocols
travishepworth d439fdc
Merge remote-tracking branch 'origin/main' into EAM-Callback
travishepworth a6ec5ea
Update cloudEvent
travishepworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @travishepworth ,
Some comments from my side. According to Commonalities (https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Event-Subscription-and-Notification-Guide.md), the expected response code for notifications is
204instead of202.In addition to that, some errors are also mandatory to be included on any notifications. The Following Error codes must be present:
I recommend that we use the template available at Commonalities repo: https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I can start looking at implementing based off the template and the missing codes.