Skip to content

Release r1.2 (Fall'25 M4)#33

Merged
ToshiWakayama-KDDI merged 14 commits intocamaraproject:mainfrom
ToshiWakayama-KDDI:toshi-kyc-match-fall25-M4
Sep 12, 2025
Merged

Release r1.2 (Fall'25 M4)#33
ToshiWakayama-KDDI merged 14 commits intocamaraproject:mainfrom
ToshiWakayama-KDDI:toshi-kyc-match-fall25-M4

Conversation

@ToshiWakayama-KDDI
Copy link
Contributor

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of kyc-match v0.4.0

Which issue(s) this PR fixes:

Fixes # N/A

Special notes for reviewers:

Before creating this PR, there was an error in the test scenarios (.feature file) detected by the centralised linting tool. As we are not sure if it is really an error, we have asked Commonalities about the error (Discussion #519 camaraproject/Commonalities#519 ) and this PR is created with the test scenario (.feature file) kept as is. ( @hdamker as Release Management is awere of it.)

Changelog input

 release-note
 - Publication of Fall'25 M4 public release of kyc-match v0.4.0

Additional documentation

None

@ToshiWakayama-KDDI
Copy link
Contributor Author

I have just created this PR by the M4 deadline 2025-08-31. Thanks.

@FabrizioMoggio
Copy link
Contributor

I have just created this PR by the M4 deadline 2025-08-31. Thanks.

@ToshiWakayama-KDDI I'm sorry, on Friday I was travelling back from 3GPP SA5.

@FabrizioMoggio
Copy link
Contributor

@ToshiWakayama-KDDI I can not add text in a review or modify the files apparently, at least I wasn't able to. SO I live my comment here. OAS file (YAML), line 28, in he image URL the release number must be updated from r1.1 to r1.2

@ToshiWakayama-KDDI
Copy link
Contributor Author

@ToshiWakayama-KDDI I can not add text in a review or modify the files apparently, at least I wasn't able to. SO I live my comment here. OAS file (YAML), line 28, in he image URL the release number must be updated from r1.1 to r1.2

No worries. So, you visited Gothenburg, didn't you? Thank you, @FabrizioMoggio, for pointing it out. I will correct the image URL. Probably Fill-in, too.

Best,
Toshi

@FabrizioMoggio
Copy link
Contributor

@ToshiWakayama-KDDI I can not add text in a review or modify the files apparently, at least I wasn't able to. SO I live my comment here. OAS file (YAML), line 28, in he image URL the release number must be updated from r1.1 to r1.2

No worries. So, you visited Gothenburg, didn't you? Thank you, @FabrizioMoggio, for pointing it out. I will correct the image URL. Probably Fill-in, too.

Best, Toshi

Yes indeed :-) a very nice town.

Copy link
Contributor

@FabrizioMoggio FabrizioMoggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Kevsy
Copy link
Contributor

Kevsy commented Sep 9, 2025

(Note we're checking on the linting error, which believes you have too many scenarios - even though there are only 21 which should be ok)

ToshiWakayama-KDDI and others added 4 commits September 10, 2025 19:43
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Wrong x-correlator new format PR
@ToshiWakayama-KDDI
Copy link
Contributor Author

But I have just found an error in L.44. L.44 indicates CallForwardingSignal PR #186, which is wrong, and it should be KYC Match PR #16 Update x-correlator format. So, I will commit the suggestion now, and then will do another commit to correct L.44 as well as L.85 (for r1.1).

I have just done this.

Thanks.

@rartych
Copy link

rartych commented Sep 10, 2025

(Note we're checking on the linting error, which believes you have too many scenarios - even though there are only 21 which should be ok)

@Kevsy @ToshiWakayama-KDDI @FabrizioMoggio The linting configuration was fixed temporarily (the final update will be decided in Commonalities) - the Megalinter check is clean now

@ToshiWakayama-KDDI
Copy link
Contributor Author

(Note we're checking on the linting error, which believes you have too many scenarios - even though there are only 21 which should be ok)

@Kevsy @ToshiWakayama-KDDI @FabrizioMoggio The linting configuration was fixed temporarily (the final update will be decided in Commonalities) - the Megalinter check is clean now

Great! Thank you so much, @rartych . Actually, when I finished the commits above, I did not see any linting errors, so, I guessed some updates had been made for the admin side.

So, I think we will be ready to go, once Codeowners approve. @fernandopradocabrillo , @GillesInnov35 , please review and approve this PR.

Best,
Toshi

@ToshiWakayama-KDDI
Copy link
Contributor Author

Hi @fernandopradocabrillo , @GillesInnov35 , cc @FabrizioMoggio ,

It was found that externalDocs object is missing in the kyc-match yaml, so, please wait for your review/approval. I will add it right now.

Best regards,
Toshi

@ToshiWakayama-KDDI
Copy link
Contributor Author

Hi @fernandopradocabrillo , @GillesInnov35 , cc @FabrizioMoggio ,

externalDocs object has been added in the yaml. In addition, I have moved two lines, one for the kyc-match version, and one for Commonalities version.

I think all done now, so, please review the PR and approve.

Best regards,

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@ToshiWakayama-KDDI
Copy link
Contributor Author

Great! Thanks very much, @Kevsy .

Hi @fernandopradocabrillo , @GillesInnov35 . We need your approval (at least, either of you) to proceed with this PR, so, please.

Many thanks,
Toshi

Copy link
Contributor

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo
Copy link
Contributor

Great! Thanks very much, @Kevsy .

Hi @fernandopradocabrillo , @GillesInnov35 . We need your approval (at least, either of you) to proceed with this PR, so, please.

Many thanks, Toshi

Done. Thanks @ToshiWakayama-KDDI for taking care of this PR

@ToshiWakayama-KDDI
Copy link
Contributor Author

Allow me to merge the PR right now, please, though we have not got Gilles' approval, as we do not have time for the M5 deadline.

Many thanks,
Toshi

@ToshiWakayama-KDDI ToshiWakayama-KDDI merged commit eaad6f6 into camaraproject:main Sep 12, 2025
2 checks passed
@ToshiWakayama-KDDI ToshiWakayama-KDDI deleted the toshi-kyc-match-fall25-M4 branch January 5, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants