Skip to content

Remove idDocument related errors#54

Merged
fernandopradocabrillo merged 2 commits intocamaraproject:mainfrom
fernandopradocabrillo:remove-id-document-errors
Feb 11, 2026
Merged

Remove idDocument related errors#54
fernandopradocabrillo merged 2 commits intocamaraproject:mainfrom
fernandopradocabrillo:remove-id-document-errors

Conversation

@fernandopradocabrillo
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature
  • documentation
  • tests

What this PR does / why we need it:

  • Remove the 403 errors related to the verification of the idDocument
  • Remove the scenarios from the testplan

Which issue(s) this PR fixes:

Fixes #49

@GillesInnov35
Copy link
Contributor

@fernandopradocabrillo , if I well understand the aim of this PR is to manage the idDocument property like the others properties even if some Operators perform an additional level of validation based on the idDocument. Do you confirm ?
I support this proposition. Let's see what others contributors think about that.

Copy link
Contributor

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering idDocumentshould be handled in the same way as the other properties. I support

@fernandopradocabrillo
Copy link
Contributor Author

@ToshiWakayama-KDDI @GillesInnov35 Yes! that's the proposal. Leave the idDocument as any other property and remove from the standard the rules for the "additional validation". If any Operator has this kind of validations they can handle it with the current errors agreeed in Commonalities.

@fernandopradocabrillo
Copy link
Contributor Author

Hi @ToshiWakayama-KDDI, did you have the chance to check this topic internally?

Copy link
Contributor

@ToshiWakayama-KDDI ToshiWakayama-KDDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @fernandopradocabrillo . Fine with us. Sorry for the delay.

@ToshiWakayama-KDDI
Copy link
Contributor

Hi @fernandopradocabrillo ,
Sorry for the delay. I have just approved it, so please merge it.

@fernandopradocabrillo fernandopradocabrillo merged commit d2eb9ea into camaraproject:main Feb 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "idDocument" related errors

3 participants