Update error schema for compliance with Commonalities r3.3#70
Update error schema for compliance with Commonalities r3.3#70eric-murray wants to merge 1 commit intocamaraproject:mainfrom
Conversation
Masa8106
left a comment
There was a problem hiding this comment.
@eric-murray , thank you for opening this PR.
As far as I see Commonalities repository, there is a PR#517 regarding the order of status, code, and message.
So, I don't think it is needed to change the order of them. What do you think?
|
Hi @Masa8106 Predicting the future can be tricky. This PR is for compliance with Commonalties r3.3, which is what is claimed in the M4 release PR #65. Any change in Commonalities will require an r3.4. So we either merge this PR for compliance with Commonalities r3.3, and create an additional PR if and when Commonalities r3.4 is created, or proceed on the assumption that Commonalities r3.4 will be created, and update the error schema and the M4 PR accordingly based on PR#517. I don't have a strong opinion |
|
@eric-murray , thank you for your reply. I am thinking I prefer the later, that is, to proceed on the assumption that Commonalities r3.4 will be created, and update the error schema and the M4 PR accordingly based on camaraproject/Commonalities#517. This is because at least AgeVerification API will proceed with that way. |
|
@Masa8106 |
What type of PR is this?
What this PR does / why we need it:
This PR updates the error schema for compliance with Commonalities r3.3
Which issue(s) this PR fixes:
Fixes #N/A
Special notes for reviewers:
None
Changelog input
Additional documentation
None