Skip to content

Add test definitions#50

Merged
benhepworth merged 10 commits intocamaraproject:mainfrom
cablelabs:feat/issue24-add-test-definitions
Jul 17, 2025
Merged

Add test definitions#50
benhepworth merged 10 commits intocamaraproject:mainfrom
cablelabs:feat/issue24-add-test-definitions

Conversation

@benhepworth
Copy link
Contributor

@benhepworth benhepworth commented Jul 1, 2025

What type of PR is this?

  • tests

What this PR does / why we need it:

Add initial test definitions

Which issue(s) this PR fixes:

Fixes #24

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@benhepworth benhepworth self-assigned this Jul 1, 2025
@benhepworth benhepworth mentioned this pull request Jul 1, 2025
Closed
@ALIIQBAL786
Copy link

ALIIQBAL786 commented Jul 2, 2025

Dear @benhepworth,
It seems like you worked a lot on these test scenarios. Everything seems fine to me.

@ALIIQBAL786
Copy link

ALIIQBAL786 commented Jul 2, 2025

Let me know if you need any help from my side.

@benhepworth
Copy link
Contributor Author

benhepworth commented Jul 2, 2025

@maheshc01 @Kevsy - this should be the last PR to review before I create the release PR. Will one of you take a look at it today please? Thanks!

Kevsy
Kevsy requested changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Feature files need to follow the guidance here: that includes the Feature name with the version aligned with the version in the YAML, the Background template, scenario structure/tagging/naming and request setup

@benhepworth
Copy link
Contributor Author

benhepworth commented Jul 8, 2025

thx @Kevsy - I think it is good now. will you take another look?

@benhepworth benhepworth requested a review from Kevsy July 9, 2025 15:29
Kevsy
Kevsy reviewed Jul 17, 2025
View reviewed changes
Kevsy
Kevsy reviewed Jul 17, 2025
View reviewed changes
Kevsy
Kevsy reviewed Jul 17, 2025
View reviewed changes
Kevsy
Kevsy reviewed Jul 17, 2025
View reviewed changes
Kevsy
Kevsy requested changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version numbers in Feature headings need updating (see suggestions) otherwise LGTM

benhepworth and others added 6 commits July 17, 2025 04:43
@benhepworth @Kevsy
Update code/Test_definitions/session-insights-deleteSession.feature
b5e44a8 
update version

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@benhepworth @Kevsy
Update code/Test_definitions/session-insights-getSession.feature
5187824 
update version

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@benhepworth @Kevsy
Update code/Test_definitions/session-insights-retrieveSessions.feature
9da1d5e 
update version

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@benhepworth @Kevsy
Update code/Test_definitions/session-insights-sendMetrics.feature
88fdac5 
update version

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@benhepworth
Update version
e619614
@benhepworth
Update based on Kevin's feedback to align with Commonalities
7dfd547
@benhepworth
Copy link
Contributor Author

benhepworth commented Jul 17, 2025

@Kevsy - thx for the review. I think this is good now. I missed one file for the re-alignment (get session test) and added that as (hopefully) the last commit and added the versions to all of them. Will you take another look?

Kevsy
Kevsy reviewed Jul 17, 2025
View reviewed changes
Kevsy
Kevsy requested changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above for changes/suggestions

@benhepworth @Kevsy
Update code/Test_definitions/session-insights-getSession.feature
146e7ec 
match commonalities 0.6 XCorellator

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Kevsy
Kevsy approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benhepworth benhepworth merged commit ec86746 into camaraproject:main Jul 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kevsy Kevsy Kevsy approved these changes

@maheshc01 maheshc01 Awaiting requested review from maheshc01 maheshc01 is a code owner

Assignees

@benhepworth benhepworth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Test Definitions

3 participants

@benhepworth @ALIIQBAL786 @Kevsy