Create a resource for an API consumer to retrieve their registration information#78
Create a resource for an API consumer to retrieve their registration information#78alpaycetin74 wants to merge 8 commits intomainfrom
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
|
Short comment on terminology: the issue says "customer", here "client" is used, but if the API Consumer is meant, than "API Consumer" would be the right term according to https://github.com/camaraproject/Commonalities/blob/main/documentation/Glossary.md |
|
thanks @alpaycetin74 , I see that Commonalities recommend for pagination https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#41-pagination
|
Thanks @GillesInnov35 I'll add 206 code and a specific example for 400 error. |
add 206 response to GET /registrations for paginated responses. Remove pagination headers from 200 response.
|
hello @GillesInnov35 , I added http 206 response code. I'll keep an eye on that and adapt if commonality guidelines change. Thank you. |
GillesInnov35
left a comment
There was a problem hiding this comment.
LGTM, thanks @alpaycetin74
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Create a new API resource for an API consumer to retrieve a list of their existing registrations.
This may be useful in case a consumer loses track of the registration ids they have received when they had created registrations with the POST request.
Which issue(s) this PR fixes:
Fixes #70
Special notes for reviewers:
Changelog input
Additional documentation